Stream Tag Builder: Support :renderable arguments
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @swanson, since this started as a conversation on the Hotwired discord. |
seanpdoyle
force-pushed
the
stream-tag-builder-support-renderable
branch
4 times, most recently
from
bf65ac0
to
c51fe26
Compare
seanpdoyle
force-pushed
the
stream-tag-builder-support-renderable
branch
4 times, most recently
from
bb2981f
to
6c04a1b
Compare
When passed a valid `:renderable` option (like an object that responds to `#render_in`), treat that object as both the `<turbo-stream>` element's template contents _and_ attempt to treat it as the target. For example, consider a simplified "component" class: ```ruby class Component extend ActiveModel::Naming def initialize(id:, content:) = (@id, @content = id, content) def render_in(...) = @content def to_key = [@id] end component = Component.new(id: 1, content: "Hello, world") turbo_stream.update(component) # => <turbo-stream action="update" target="component_1"><template>Hello, world</template></turbo-stream> ```
seanpdoyle
force-pushed
the
stream-tag-builder-support-renderable
branch
from
6c04a1b
to
5038ed8
Compare
|
@brunoprietog are you able to review this? |
brunoprietog
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passed a valid
:renderableoption (like an object that responds to#render_in), treat that object as both the<turbo-stream>element's template contents and attempt to treat it as the target.For example, consider a simplified "component" class: