Add Type Safety Guards to turbo/fetch_requests
#403
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, GET
<form>
submissions without a Fetch Options{ body: }
raise the following:Through the exercise of attempting to port the
turbo/fetch_requests
module toTypeScript, we've identified some potential edge cases in the algorithm that determines a request's HTTP method.
Even if the migration to TypeScript doesn't come to fruition for some time, those edge cases should be addressed sooner rather than later.
This commit adds more "type safety" motivated conditionals and guards to make sure that values are present before overriding them.