Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build update #273

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Build update #273

merged 4 commits into from
Apr 26, 2023

Conversation

jhutarek
Copy link
Contributor

This PR updates the build config to bring the library up to date:

  • Android Gradle plugin to 8.0
  • Gradle wrapper to 8.1.1
  • Java targets to Java version 17

AGP 8 brings some breaking changes (non-transitive R class, BuildConfig not generated by default) that were also addressed.

@jhutarek jhutarek requested a review from jayohms April 26, 2023 17:01
jayohms
jayohms approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@jayohms jayohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks 👍

@jhutarek jhutarek merged commit c450cec into main Apr 26, 2023
@jhutarek jhutarek deleted the build-update branch April 26, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayohms jayohms jayohms approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhutarek @jayohms