Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent web page screenshot scaling down in some cases #267

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

mbarta
Copy link
Contributor

@mbarta mbarta commented Mar 21, 2023

Fixes #206:

... when you have an input field in a bottom modal sheet and you focus on it to type, the viewport for the page behind the modal shrinks a bit ...

It does so by changing the scaleType of the ImageView that holds a screenshot of a detached WebView page to matrix. Not setting any value programmatically leaves the image unchanged even when the height of the ImageView changes (due to the keyboard popping up).

@mbarta mbarta requested review from jayohms and jhutarek March 21, 2023 18:32
@mbarta mbarta self-assigned this Mar 21, 2023
Copy link
Collaborator

@jayohms jayohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@mbarta mbarta merged commit 7048faf into main Mar 21, 2023
@mbarta mbarta deleted the screenshot_scale_matrix branch March 21, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Main page shrinks when keyboard shows up in the bottom sheet modal
2 participants