Set WebView's height to wrap content if its parent is ScrollingView #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayohms
reviewed
Mar 21, 2023
Comment on lines
37
to
42
| webView.updateLayoutParams { | ||
| height = when (webViewContainer) { | ||
| is ScrollingView -> LayoutParams.WRAP_CONTENT | ||
| else -> LayoutParams.MATCH_PARENT | ||
| } | ||
| } |
There was a problem hiding this comment.
Does this work if you move this down to line 55? It feels safer to me to only update the layout params if we know that we're attaching the webView to a new parent.
There was a problem hiding this comment.
Right, makes sense. It does work inside of that block the same 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to support proper nested scrolling of a WebView inside of a BottomSheet introduced in #261 unfortunately caused some side-effects to other full-height screens in some cases related to scrolling of nested content.
Therefore, this PR restores the default layout parameters of the shared WebView to
MatchParentand only if the WebView's parent isScrollingView, its height is set toWrapContent.