Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modifier to filter keyboard events. #442
Add modifier to filter keyboard events. #442
Changes from 14 commits
aad454a
2c9769d
c2e30a4
49503b7
18d6fa2
10ee3de
ff8cf8b
2fe8852
5693106
cf5473c
9d8fa19
4e13612
2a0bcdf
4e55fea
3818734
c8e4a41
53e1cdf
c3262cc
e0fdab6
44a7b4a
a4ce7fe
b97faa9
9c31747
d5cb12e
59bcdb4
c1d2d6a
fa297c5
15f09c9
630a685
a3ad75c
1b59313
1226501
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey ! My first PR review on this repo :D
Are you only checking if
keyFilter
exists inkeyMappings
? If yes, can this be simplified toThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll apply it if they decide they still need this PR. 😄