Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Permission Check Over Force Scan Toggle #434

Closed
3 tasks
amansinghbais opened this issue Jan 31, 2025 · 1 comment
Closed
3 tasks

Add Permission Check Over Force Scan Toggle #434

amansinghbais opened this issue Jan 31, 2025 · 1 comment
Assignees
@amansinghbais

Comments

@amansinghbais
Copy link
Contributor

amansinghbais commented Jan 31, 2025 •
edited
Loading

What is the motivation for adding/enhancing this feature?

The Force Scan toggle currently lacks a permission check, allowing all users to enable/disable it. To ensure only authorized users can modify this setting, a permission check should be implemented.

Permission: COMMON_ADMIN

What are the acceptance criteria?

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information
@amansinghbais amansinghbais self-assigned this Jan 31, 2025
@amansinghbais amansinghbais moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jan 31, 2025
amansinghbais added a commit to amansinghbais/receiving that referenced this issue Jan 31, 2025
@amansinghbais
Improved: added permission check over the force scan toggle (hotwax#434)
467ea98
@amansinghbais amansinghbais mentioned this issue Jan 31, 2025
Merged
1 task
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Jan 31, 2025
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jan 31, 2025
ravilodhi added a commit that referenced this issue Jan 31, 2025
@ravilodhi
Merge pull request #435 from amansinghbais/#434
e79169f 
Improved: added permission check over the force scan toggle (#434)
@ravilodhi ravilodhi moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jan 31, 2025
@dt2patel
Copy link
Contributor

dt2patel commented Feb 4, 2025

Checked UAT version of app that user is unable to change settings without common_admin privileges

@dt2patel dt2patel closed this as completed Feb 4, 2025
@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amansinghbais amansinghbais

Labels
None yet
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dt2patel @amansinghbais