Merge pull request #51 from azkyakhan/#21aqct8

hotwax · Feb 23, 2022 · 55a3e58 · 55a3e58
2 parents 4105bd3 + 506ca11
commit 55a3e58
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 6 deletions.
diff --git a/changelogs/unreleased/-21aqct8.yml b/changelogs/unreleased/-21aqct8.yml
@@ -0,0 +1,6 @@
+---
+title: Removed fullscreen=true from ion-content of all pages
+ticket_id: "#21aqct8"
+merge_request: 51
+author: azkyakhan
+type: changed
diff --git a/src/views/catalog.vue b/src/views/catalog.vue
@@ -20,7 +20,7 @@
       </ion-toolbar>
     </ion-header>
 
-    <ion-content :fullscreen="true">
+    <ion-content>
       <!--Segment content -->
       <div class="search-filter">
         <ion-searchbar />

diff --git a/src/views/login.vue b/src/views/login.vue
@@ -1,6 +1,6 @@
 <template>
   <ion-page>
-    <ion-content :fullscreen="true">
+    <ion-content>
       <div class="flex">
         <form class="login-container" @keyup.enter="login(form)" @submit.prevent="login(form)">
           <img src="../assets/images/hc.png"/>

diff --git a/src/views/orders.vue b/src/views/orders.vue
@@ -18,7 +18,7 @@
       </ion-toolbar>
     </ion-header>
 
-    <ion-content :fullscreen="true">
+    <ion-content>
       <div class="header">
         <div class="search">
           <ion-searchbar @ionFocus="selectSearchBarText($event)" @ionClear="query.queryString = ''; updateQuery()" :value="query.queryString" v-on:keyup.enter="query.queryString = $event.target.value; updateQuery()"> </ion-searchbar>

diff --git a/src/views/product-details.vue b/src/views/product-details.vue
@@ -17,7 +17,7 @@
       </ion-toolbar>
     </ion-header>
 
-    <ion-content :fullscreen="true">
+    <ion-content>
       <div class="header">
         <div class="product-image">
           <!-- TODO Create a separate component to handled default image -->

diff --git a/src/views/products.vue b/src/views/products.vue
@@ -14,7 +14,7 @@
       </ion-toolbar>
     </ion-header>
 
-    <ion-content :fullscreen="true">
+    <ion-content>
       <ion-searchbar @ionFocus="selectSearchBarText($event)" :placeholder="$t('Search products')" v-model="queryString" v-on:keyup.enter="getProducts()"></ion-searchbar>
 
       <!-- Empty state -->

diff --git a/src/views/settings.vue b/src/views/settings.vue
@@ -9,7 +9,7 @@
       </ion-toolbar>
     </ion-header>
 
-    <ion-content :fullscreen="true">
+    <ion-content>
       <ion-item>
         <ion-label>{{ $t("Brand") }}</ion-label>
         <ion-select @ionChange="updateBrand($event)" interface="popover" :value="selectedBrand">