Fix potential duplicate class loading issue causing memory leaks. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expand string method loads Groovy classes. It first checks the cache and, if not found, creates a new class loader each time. This behavior can lead to memory leaks when used improperly. The Shopify URL may contain dynamic values, making it unsuitable for the expand method. The systemMessageRemote.sendUrl should use constant expressions that are reusable and appropriate for caching. Updated the code to modify systemMessageRemote.sendUrl by replacing the Shopify app version directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expand string method loads Groovy classes. It first checks the cache and, if not found, creates a new class loader each time. This behavior can lead to memory leaks when used improperly.
The Shopify URL may contain dynamic values, making it unsuitable for the expand method. The systemMessageRemote.sendUrl should use constant expressions that are reusable and appropriate for caching. Updated the code to modify systemMessageRemote.sendUrl by replacing the Shopify app version directly.