Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensures all pending items are addressed before marking the cycle count as complete #635

Closed
2 tasks
ravilodhi opened this issue Jan 17, 2025 · 1 comment
Closed
2 tasks

Ensures all pending items are addressed before marking the cycle count as complete #635

ravilodhi opened this issue Jan 17, 2025 · 1 comment
Assignees
@Adameddy26
Labels
bug Something isn't working release-v2.6.1

Comments

@ravilodhi
Copy link
Contributor

Current behavior

Currently the checks are there at app side to handle this but somehow user completed the Cycle count without addressing pending review items.

Expected behavior

Check in DB for any open item in the Cycle count before marking it as completed.

Steps to reproduce the issue

Can you handle fixing this bug by yourself?

  • YES
  • NO

Environment details

  • Browser:
  • OS:
  • Code Version:

Additional information
@ravilodhi ravilodhi added the bug Something isn't working label Jan 17, 2025
@ravilodhi ravilodhi moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Jan 17, 2025
@R-Sourabh R-Sourabh moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Jan 17, 2025
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jan 17, 2025
@R-Sourabh
Improved: Added a check to allow completing the pending count only w…
9248738 
…hen no items are in the "created" state(hotwax#635)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jan 17, 2025
@R-Sourabh
Improved: fixed some spacing issue in the paylaod(hotwax#635)
b04345c
@R-Sourabh R-Sourabh mentioned this issue Jan 17, 2025
Merged
1 task
@R-Sourabh R-Sourabh moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jan 17, 2025
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jan 17, 2025
@R-Sourabh
Improved: Changed the service name responsible for fetching the item …
8202901 
…count in a cycle count(hotwax#635)
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jan 17, 2025
@R-Sourabh
Improved: updated the toast message & added toast message on api fail(h…
65a1fca 
…otwax#635)
ravilodhi added a commit that referenced this issue Jan 17, 2025
@ravilodhi
Merge pull request #636 from R-Sourabh/#635-pending-count-complete-check
a4ba828 
 Improved: Added a check to allow completing the pending count only when no items are in the "created" state(#635)
@ravilodhi ravilodhi moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jan 17, 2025
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jan 17, 2025
@R-Sourabh
Improved: Added a loader in the complete count function that complete…
60bc6b7 
…s the pending count(hotwax#635)
@R-Sourabh R-Sourabh mentioned this issue Jan 17, 2025
Merged
1 task
R-Sourabh added a commit to R-Sourabh/inventory-count that referenced this issue Jan 17, 2025
@R-Sourabh
Improved: dismiss loader before the we route to closed page(hotwax#635)
d28a310
ymaheshwari1 added a commit that referenced this issue Jan 17, 2025
@ymaheshwari1
Merge pull request #637 from R-Sourabh/#635-pending-count-complete-check
a2f12da 
Improved: Added a loader in the complete count function that completes the pending count(#635)
@Adameddy26 Adameddy26 assigned Adameddy26 and unassigned R-Sourabh Jan 20, 2025
@Adameddy26 Adameddy26 moved this from ⏸️ Dev complete to ⚒️ In QA in Digital Experience Platform Jan 20, 2025
@Adameddy26
Copy link

Issue verified and working fine in release v2.6.1. Hence, closing this issue.

@github-project-automation github-project-automation bot moved this from ⚒️ In QA to ✅ Done in Digital Experience Platform Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adameddy26 Adameddy26

Labels
bug Something isn't working release-v2.6.1
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ravilodhi @R-Sourabh @Adameddy26