Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: added validation on fav button in modal to associate facilites, groupType and product to a facility group (#224) #227

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Mar 19, 2024

Related Issues

Related Issue #224

Short Description and Why It's Useful

Added check on fav button in below modals to disabled when nothing changes.

  • Add facility to group modal.
  • Add product stores to group modal.
  • Select grouptypes for a group modal.

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

@amansinghbais amansinghbais changed the title Improved: added validation on fav icon in modal to associate facilites, groupType and product to a facility group (#223) Improved: added validation on fav icon in modal to associate facilites, groupType and product to a facility group (#224) Mar 19, 2024
@amansinghbais amansinghbais changed the title Improved: added validation on fav icon in modal to associate facilites, groupType and product to a facility group (#224) Improved: added validation on fav button in modal to associate facilites, groupType and product to a facility group (#224) Mar 19, 2024
@ymaheshwari1 ymaheshwari1 merged commit 6e521a7 into hotwax:main Mar 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants