Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Spinner in timezone modal so users can see that data is being fetched #184

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

Ritika-Patel08
Copy link
Contributor

@Ritika-Patel08 Ritika-Patel08 commented Jan 23, 2024

Related Issues

Closes #

Short Description and Why It's Useful

Added ion-spinner inside the Timezone modal to enhance UI

Screenshots of Visual Changes before/after (If There Are Any)

image

Contribution and Currently Important Rules Acceptance

@Ritika-Patel08 Ritika-Patel08 changed the title Fixed: spinner inside the ion-item to enhance UI Implemented: Spinner in timezone modal so users can see that data is being fetched Jan 25, 2024
<ion-spinner name="crescent" />
<p>{{ translate("Fetching TimeZones")}}</p>
<ion-item lines="none">
<ion-spinner color="secondary" name="crescent" slot="start" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Indentation

@ravilodhi ravilodhi merged commit 8ff237c into hotwax:main Mar 15, 2024
2 checks passed
@Adameddy26
Copy link

Verified and working fine in release v1.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants