Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted: changes for null check for externalId those were removed in conflict resolution(#133) #139

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

ymaheshwari1
Copy link
Contributor

Related Issues

Closes #133

Short Description and Why It's Useful

The changes for checking null value for externalId were removed while resolving conflicts in this PR #108
https://github.com/hotwax/facilities/pull/108/files#diff-a2d088e273ebf6b970cc5096d9c2bd0dc9a006e2f4ba943d083f9ccf2ba401f3L337

Screenshots of Visual Changes before/after (If There Are Any)

Contribution and Currently Important Rules Acceptance

@ravilodhi ravilodhi merged commit 805664c into hotwax:main Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facility ID card showing when no ID
2 participants