Reverted: changes for null check for externalId those were removed in conflict resolution(#133) #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #133
Short Description and Why It's Useful
The changes for checking null value for externalId were removed while resolving conflicts in this PR #108
https://github.com/hotwax/facilities/pull/108/files#diff-a2d088e273ebf6b970cc5096d9c2bd0dc9a006e2f4ba943d083f9ccf2ba401f3L337
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance