-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented: system groups section on find groups page (#73) #123
Merged
ravilodhi
merged 17 commits into
hotwax:main
from
amansinghbais:facility-group-security-groups
Dec 21, 2023
Merged
Implemented: system groups section on find groups page (#73) #123
ravilodhi
merged 17 commits into
hotwax:main
from
amansinghbais:facility-group-security-groups
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity-group-security-groups
…lity-group-security-groups
…facilityGroupTypes
ymaheshwari1
requested changes
Dec 19, 2023
ymaheshwari1
requested changes
Dec 20, 2023
ymaheshwari1
approved these changes
Dec 21, 2023
ravilodhi
reviewed
Dec 21, 2023
src/views/FindGroups.vue
Outdated
</ion-list-header> | ||
<ion-item v-for="groupType in facilityGroupTypes" :key="groupType.facilityGroupId"> | ||
<ion-label> | ||
{{ groupType.description }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Display groupTypeId if there is no description set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #73
Short Description and Why It's Useful
Implemented system groups section on the find groups page.
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance