- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup dockerfiles, remove duplicates, upgrade PDM #6554
Cleanup dockerfiles, remove duplicates, upgrade PDM #6554
Conversation
Dockerfile
Outdated
RUN apt-get update && apt-get install --no-install-recommends -y \ | ||
build-essential \ | ||
libffi-dev \ | ||
libgeos-dev | ||
libgeos-dev \ | ||
postgresql-server-dev-15 \ | ||
python3-dev |
Check notice
Code scanning / SonarCloud
Arguments in long RUN instructions should be sorted Low
|
@dakotabenjamin i just verified this, can be merged. |
Errors after merging, which weren't caught because they are in server instantiation:
In addition, a slew of errors compiling sklearn during pip install.
|
Any way we can test the Cloudformation (I assume) stuff locally? It's a bit baffling how the libgeos install would have broken when this PR updates dockerfiles π― The second issue around the numpy version can be fixed by pinning the numpy version explicitly (if sklearn requires this) |
@spwoodcock We can use https://www.localstack.cloud/ to run the EC2 instance with the defined user-data scripts locally, but i am not sure if it supports the AMI we are using. Let me check. |
What type of PR is this? (check all applicable)
Related Issue
Fixes #6552
Describe this PR
--workers
flag for Gunicorn (can be set byWEB_CONCURRENCY
env var instead).inherit_metadata
strategy (required PDM > 2.15).Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?