-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to delete a user's information #6334
Open
tsmock
wants to merge
9
commits into
hotosm:develop
Choose a base branch
from
facebook:feat/6002-delete-user-accounts
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+504
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmock
force-pushed
the
feat/6002-delete-user-accounts
branch
6 times, most recently
from
April 16, 2024 20:46
dc29a65
to
5e8e418
Compare
tsmock
changed the title
backend: Add ability to delete a user
Add ability to delete a user's information
Apr 17, 2024
tsmock
force-pushed
the
feat/6002-delete-user-accounts
branch
2 times, most recently
from
May 7, 2024 13:35
009b59c
to
f71048f
Compare
Quality Gate passedIssues Measures |
v4.8.1 Latest changes to staging
Optimise CSV file download within explore projects for staging setup
v4.8.2 on staging
v4.8.3 staging setup
Mapswipe changes on staging
Signed-off-by: Taylor Smock <tsmock@meta.com>
…hammering API Signed-off-by: Taylor Smock <tsmock@meta.com>
Signed-off-by: Taylor Smock <tsmock@meta.com>
Of specific note, the background-image check passes prior to the previous commit because two renders happen before the test continues. With the new code, only one render happens. This may have been a source of intermittent test failures in the past. Signed-off-by: Taylor Smock <tsmock@meta.com>
tsmock
force-pushed
the
feat/6002-delete-user-accounts
branch
from
January 21, 2025 17:35
f71048f
to
da9810f
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Fixes #6002 (backend; frontend UI not done)
Describe this PR
This adds an API call (specifically, a
DELETE
to/users/<int:user_id>
(specific user) and/users
(users no longer on OSM)).As much user-supplied information as possible is redacted, with the following exceptions:
Screenshots
N/A
Alternative Approaches Considered
Deleting user from database completely. Rejected partially due to complexity of figuring out what to do with mapped/validated tasks and user blocks.
Review Guide
For the code path that redacts users from the DB if the user deleted their account in OSM, user 535043 is known to no longer exist.
Sample psql command for user 535043:
$ curl -X DELETE -H 'Authorization: Token ${TOKEN}' localhost:5000/api/v2/users/
Further questions:
Is the OSM server admin team OK with us hitting
/user/:id
frequently?EDIT: TomH pointed me at https://planet.openstreetmap.org/users_deleted/users_deleted.txt .