Support for multiple languages in project edit view #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeMartinezG
force-pushed
the
feature/edit-locales
branch
4 times, most recently
from
6446c5c to
cafb475
Compare
|
note. Included markdown preview |
willemarcel
suggested changes
Dec 23, 2019
There was a problem hiding this comment.
@JorgeMartinezG do you think we could have a realtime markdown preview? If not, we could use tabs instead of the Preview button, as an action button below the text input makes the interface a bit confusing.
A bug that I noticed is that when you try to type in the middle of the text, the cursor is moved to the end of the text after typing one character. I think it's related to the onChange state update.
I noticed a bug in the API: #2086
JorgeMartinezG
force-pushed
the
feature/edit-locales
branch
2 times, most recently
from
4026eaf to
d74646d
Compare
|
@willemarcel I updated the branch with your comments and feedback.
However I receive an error on circle ci. I ran tests locally successfully. Checking on Internet, it seems related to the node version which circle-ci uses. |
willemarcel
approved these changes
Dec 24, 2019
willemarcel
force-pushed
the
feature/edit-locales
branch
from
3b6d5c6 to
50c2a25
Compare
pantierra
pushed a commit
that referenced
this pull request
Apr 22, 2020
* Support for multiple languages in project edit view * change style of preview area Co-authored-by: Wille Marcel <wille.yyz@gmail.com>
pantierra
pushed a commit
that referenced
this pull request
Apr 22, 2020
* Support for multiple languages in project edit view * change style of preview area Co-authored-by: Wille Marcel <wille.yyz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.