Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate sync button #2100

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Relocate sync button #2100

merged 6 commits into from
Jan 22, 2025

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented Jan 21, 2025

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

  • Mapper frontend: relocate entity status sync button
  • Management frontend: update task status on SYNC STATUS click

Screenshots

image
image

Alternative Approaches Considered

Tried to update the project task status using this approach:
/task API fetch (same as in this approach) --> update the projectTaskBoundries state directly with the API response
This was a simple approach but it has a downside as it was causing the task layer to zoom and vanish for a split of seconds due to rerender.

@github-actions github-actions bot added the bug Something isn't working label Jan 21, 2025
@NSUWAL123 NSUWAL123 marked this pull request as draft January 21, 2025 12:03
@github-actions github-actions bot added the frontend Related to frontend code label Jan 22, 2025
@NSUWAL123 NSUWAL123 marked this pull request as ready for review January 22, 2025 11:32
@NSUWAL123 NSUWAL123 requested a review from spwoodcock January 22, 2025 11:32
@spwoodcock spwoodcock merged commit 3fd3665 into development Jan 22, 2025
6 checks passed
@spwoodcock spwoodcock deleted the fix/relocate-sync-btn branch January 22, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants