Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity pulse effect on rejected submissions #2018

Merged
merged 54 commits into from
Jan 20, 2025

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented Dec 23, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

  • Pulse entity if submission to that entity marked as hasIssues
  • Remove rejected entity submission state, retaining only approved and hasIssues state

Screenshots

Screencast.from.17-1-25.03.32.55.+0545.webm

[optional] What gif best describes this PR or how it makes you feel?

giphy (1)

@github-actions github-actions bot added enhancement New feature or request frontend Related to frontend code labels Dec 23, 2024
@NSUWAL123
Copy link
Contributor Author

Now everything works fine but one small problem due to the current workflow:
For example, if a submission has been made to an entity and it has been marked as bad then the obvious behavior would be that the entity's color would be red and the highlighting effect would be visible. Now the issue arises when another submission is made to that entity. The entity's color is changed to green but the highlighting effect remains until the submission is marked as approved since delete geom record API is triggered on marking the submission as approved.
So, basically in our current workflow, we are not able to delete geometry records once a submission is made to the entity whose previous submission has been marked hasIssues leading to the entity color green while having red pulse effect.

image

@NSUWAL123 NSUWAL123 marked this pull request as ready for review January 17, 2025 10:15
@NSUWAL123 NSUWAL123 requested a review from spwoodcock January 17, 2025 10:15
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes, two frontend πŸ˜…
Good work!

Hopefully we don't have many changes that affect both the React and Svelte frontends at once.

Thanks for commenting on the case of two submissions too πŸ‘ we can return to that in the future if needed

@spwoodcock spwoodcock merged commit 1d02cd4 into development Jan 20, 2025
9 checks passed
@spwoodcock spwoodcock deleted the feat/pulse-problematic-entity branch January 20, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code enhancement New feature or request frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants