This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Use actual lookup so we don’t 404 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotmeteor
approved these changes
Oct 19, 2022
|
@edalzell Check that... can you go ahead and fix them? |
|
I can take a look in a bit ya. In the meantime @hotmeteor will you be doing a release? Or are you waiting for the tests? |
|
I can cut a release now if you want. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
Calling
FrontControllerthrows a 404 if the data doesn't exist. Calling the actual lookup is better.@hotmeteor sorry I didn't write a test, but the tests don't run (blueprint is missing). I can help get those going again, if you like.