Add postprocessing for email actions and include page_name property #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butkeraites-hotglue
commented
Dec 31, 2024
butkeraites-hotglue
commented
- Implemented postprocess_record method in ContactsSink to create actions based on email and page_name configuration.
- Added page_name property to TargetActionKit for enhanced configuration options.
- Implemented postprocess_record method in ContactsSink to create actions based on email and page_name configuration. - Added page_name property to TargetActionKit for enhanced configuration options.
butkeraites-hotglue
requested review from
hsyyid,
arilton,
keyn4 and
brenhogan
- Changed the API endpoint for ContactsSink from "user" to "rest/v1/". - Added temporary handling for zip code errors by removing the "zip" field from the record. - Integrated postprocessing of records after successful updates and action creations. - Improved error logging for action creation failures, providing clearer feedback on issues. These changes aim to improve the robustness and clarity of the ContactsSink functionality.
hsyyid
reviewed
Dec 31, 2024
| @@ -7,7 +7,7 @@ class ContactsSink(ActionKitSink): | |||
| """ActionKit target sink class.""" | |||
|
|
|||
| name = "Contacts" | |||
| endpoint = "user" | |||
| endpoint = "rest/v1/" | |||
There was a problem hiding this comment.
Yes! Without it I would not be able to add users to the action page
| @@ -49,6 +49,9 @@ def upsert_record(self, record: dict, context: dict): | |||
|
|
|||
| if existing_users: | |||
| user_id = existing_users[0].get("id") | |||
| # TODO:I got {"errors": {"zip": ["Data too long! Please use a smaller value, see the schema for the maximum allowed input"]}}} | |||
| # I'm not sure if this is the correct way to handle this, but it's a temporary fix | |||
| record.pop("zip", None) | |||
There was a problem hiding this comment.
Doesn't this just mean you were providing an invalid zip?
There was a problem hiding this comment.
It was a valid one and in the schema there wasn't any valuable information on how to handle it... If I let it updating the zip it would break things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.