HGI-6642 / Add event_filter to plan, product and charge streams #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyn4
reviewed
Oct 15, 2024
tap_stripe/streams.py
Outdated
| @@ -368,6 +368,7 @@ class Plans(StripeStreamV2): | |||
| replication_key = "updated" | |||
| object = "plan" | |||
| from_invoice_items = False | |||
| event_filter = "plan.*" | |||
There was a problem hiding this comment.
for plans the reason that the event_filter is not set is because when a subscription price/plan is updated on the subscription itself the triggered event is not of type plan.* but customer.subscription.updated so we were missing those when using plan.*, I think it's not possible to request multiple event types, therefore we opted to fetch all events :c
keyn4
reviewed
Oct 15, 2024
tap_stripe/streams.py
Outdated
| @@ -580,6 +581,7 @@ class Products(StripeStreamV2): | |||
| name = "products" | |||
| replication_key = "updated" | |||
| object = "product" | |||
| event_filter = "product.*" | |||
There was a problem hiding this comment.
same as plans for products we need to get events from products.* and from invoice.*
keyn4
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.