Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HGI-7143 implemented archived products stream #114

Merged
merged 2 commits into from
Feb 7, 2025
Merged

HGI-7143 implemented archived products stream #114

merged 2 commits into from
Feb 7, 2025

Conversation

mianazmatali9
Copy link

@mianazmatali9 mianazmatali9 commented Feb 5, 2025 •
edited
Loading

  • HGI-7143 implemented archived products stream

hsyyid
hsyyid requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@hsyyid hsyyid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was done on the wrong base branch. It should've used saasgrid branch

tap_hubspot_beta/streams.py Outdated Show resolved Hide resolved
tap_hubspot_beta/tap.py Outdated Show resolved Hide resolved
@mianazmatali9 mianazmatali9 changed the base branch from master to saasgrid February 5, 2025 19:33
@mianazmatali9 mianazmatali9 changed the base branch from saasgrid to master February 5, 2025 20:47
@mianazmatali9 mianazmatali9 changed the base branch from master to saasgrid February 5, 2025 20:52
hsyyid
hsyyid reviewed Feb 5, 2025
View reviewed changes
tap_hubspot_beta/streams.py Outdated Show resolved Hide resolved
@hsyyid hsyyid merged commit fa2a279 into saasgrid Feb 7, 2025
@hsyyid hsyyid deleted the feature/hgi-7143 branch February 7, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izkapadia-hg izkapadia-hg izkapadia-hg left review comments

@hsyyid hsyyid hsyyid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mianazmatali9 @hsyyid @izkapadia-hg