Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGI-5916 / Support for custom objects #101

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

arilton
Copy link

@arilton arilton commented Dec 4, 2024

No description provided.

Copy link

@butkeraites-hotglue butkeraites-hotglue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @arilton , but I have some questions and things that I think you should take a look at. Please let me know once you finish your changes/replies 🙏

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you didn't want to add this file

th.Property("updatedByUserId", th.IntegerType),
th.Property("objectTypeId", th.StringType),
th.Property("properties", th.ArrayType(th.ObjectType(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showCurrencySymbol (Boolean) is missing, hubspotDefined (Boolean) is missing, createdAt (DateTimeType) is missing, updatedAt (DateTimeType) is missing, archivedAt (DateTimeType) is missing, referencedObjectType (String) is missing, calculationFormula (String) is missing
Check the response here: https://api.hubapi.com/crm-object-schemas/v3/schemas

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

tap_hubspot_beta/tap.py Show resolved Hide resolved
tap_hubspot_beta/tap.py Show resolved Hide resolved
tap_hubspot_beta/tap.py Show resolved Hide resolved
tap_hubspot_beta/tap.py Show resolved Hide resolved
Copy link

@butkeraites-hotglue butkeraites-hotglue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @arilton ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants