add support to to_singer to build schema from catalog #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsyyid
reviewed
Oct 29, 2024
gluestick/singer.py
Outdated
| @@ -225,13 +303,21 @@ def to_singer( | |||
| Allow or not objects to the parsed, if false defaults types to str. | |||
|
|
|||
| """ | |||
| catalog_schema = os.environ.get("USE_CATALOG_SCHEMA", False) | |||
There was a problem hiding this comment.
Shouldn't this be os.environ.get("USE_CATALOG_SCHEMA", "false") == "true"? Env vars are always strings
| @@ -196,6 +205,75 @@ def deep_convert_datetimes(value): | |||
| return value.strftime("%Y-%m-%dT%H:%M:%S.%fZ") | |||
| return value | |||
|
|
|||
| def parse_objs(x): | |||
There was a problem hiding this comment.
How come you moved this here from etl_utils.py?
There was a problem hiding this comment.
to avoid circular imports, to_export here uses to_singer from singer.py and I wanted to use this function in singer.py functions :c
| import pandas as pd | ||
| import pyarrow.parquet as pq | ||
|
|
||
| class Reader: |
There was a problem hiding this comment.
Was this just a full copy paste moving it out of etl_utils or did you change anything?
There was a problem hiding this comment.
yes full copy paste, no changes at all
hsyyid
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
to_singerto generate a schema using the catalog, it uses env varUSE_CATALOG_SCHEMAOthers: