Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-687 : Upgrade to Curator 4.2.0 and Upgrade to Guava 28.1 #686

Merged
merged 4 commits into from
Mar 17, 2020
Merged

ISSUE-687 : Upgrade to Curator 4.2.0 and Upgrade to Guava 28.1 #686

merged 4 commits into from
Mar 17, 2020

Conversation

in-park
Copy link
Contributor

@in-park in-park commented Mar 16, 2020 •
edited by raju-saravanan
Loading

Upgrade to Curator 4.2.0 and Upgrade to Guava 28.1

Fixes #687

@in-park in-park requested a review from raju-saravanan March 16, 2020 11:36
@in-park in-park changed the title [CDPD-8846][CDPD-9125] Upgrade to Curator 4.2.0 and Upgrade to Guava 28.1 Upgrade to Curator 4.2.0 and Upgrade to Guava 28.1 Mar 16, 2020
@in-park in-park requested a review from akatona84 March 16, 2020 11:40
@tamaashu
Copy link

Guava related changes look okay. Have you checked it with 'mvn dependency:tree' to see we don't get any zookeeper or guava through curator?

@in-park
Copy link
Contributor Author

in-park commented Mar 16, 2020 •
edited
Loading

Guava related changes look okay. Have you checked it with 'mvn dependency:tree' to see we don't get any zookeeper or guava through curator?

Hi @tamaashu , I updated my PR, I checked with mvn dependency:tree, no zookeeper or guava is pulled by curator related modules except for the test scope.

@raju-saravanan
Copy link
Collaborator

@in-park: Can you create a Github issue for this ? In that issue can you also include the CVEs you are addressing with this PR ?

@in-park in-park linked an issue Mar 16, 2020 that may be closed by this pull request
Upgrade to Guava 28.1 to avoid CVE-2018-10237 #687
Closed
@in-park
Copy link
Contributor Author

in-park commented Mar 16, 2020 •
edited
Loading

@in-park: Can you create a Github issue for this ? In that issue can you also include the CVEs you are addressing with this PR ?

Done:
#687

@raju-saravanan raju-saravanan changed the title Upgrade to Curator 4.2.0 and Upgrade to Guava 28.1 ISSUE-687 : Upgrade to Curator 4.2.0 and Upgrade to Guava 28.1 Mar 16, 2020
@raju-saravanan
Copy link
Collaborator

@in-park : "mvn clean install" failed with below error,

image

@in-park
Copy link
Contributor Author

in-park commented Mar 17, 2020 •
edited
Loading

@in-park : "mvn clean install" failed with below error,

image

mvn clean install is successful for me, I am wondering if the test was run with one of the previous commits? I ran into the same issue when I removed zookeeper as dependency in the test scope curator, so I added it back in the most recent commit.

raju-saravanan
raju-saravanan approved these changes Mar 17, 2020
View reviewed changes
Copy link
Collaborator

@raju-saravanan raju-saravanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, thanks @in-park for the PR

@in-park in-park merged commit 8ba935e into hortonworks:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raju-saravanan raju-saravanan raju-saravanan approved these changes

@akatona84 akatona84 Awaiting requested review from akatona84

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Guava 28.1 to avoid CVE-2018-10237
3 participants
@in-park @tamaashu @raju-saravanan