Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding backed enums for codelists #223

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

mokraemer
Copy link

Adding the backed enums in a new namespace, keeping the original names.

@horstoeko
Copy link
Owner

@mokraemer,

It is as I suspected: The builds for PHP < 8.1 do not go through. I can't merge the PR now.

@mokraemer
Copy link
Author

I see, I don't know this feature. The enums (classes) are optional and not integrated in your code, which would be the step if enums are used instead of strings.

@horstoeko
Copy link
Owner

Hi,

I see, I don't know this feature. The enums (classes) are optional and not integrated in your code

I am doing a code linting - that's why it was recognized as an error in the PHP version <= 8.0

which would be the step if enums are used instead of strings.

I would have to discontinue PHP versions <= 8.0, which would probably be rather unfavorable in the current situation... ;-)

@horstoeko horstoeko closed this Dec 18, 2024
@horstoeko horstoeko reopened this Dec 18, 2024
@horstoeko horstoeko merged commit a614cb7 into horstoeko:master Dec 18, 2024
horstoeko pushed a commit that referenced this pull request Dec 18, 2024
@horstoeko
Copy link
Owner

Hi @mokraemer,

I have found a solution to check and merge the PR. But there was at least one error in the code that I had to fix (ZugferdPaymentMeans) - there was a case of type String, which I removed. But nevertheless - good work, for which I would like to thank you. However, I have to put the matter on hold for now, as other build processes are still running on errors.

Kind reards

horstoeko pushed a commit that referenced this pull request Dec 18, 2024
horstoeko added a commit that referenced this pull request Dec 18, 2024
[ENH] Added Codelists as Enum (see PR #223)
@mokraemer
Copy link
Author

great.

Repository owner locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants