-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding backed enums for codelists #223
Conversation
It is as I suspected: The builds for PHP < 8.1 do not go through. I can't merge the PR now. |
I see, I don't know this feature. The enums (classes) are optional and not integrated in your code, which would be the step if enums are used instead of strings. |
Hi,
I am doing a code linting - that's why it was recognized as an error in the PHP version <= 8.0
I would have to discontinue PHP versions <= 8.0, which would probably be rather unfavorable in the current situation... ;-) |
Hi @mokraemer, I have found a solution to check and merge the PR. But there was at least one error in the code that I had to fix (ZugferdPaymentMeans) - there was a case of type String, which I removed. But nevertheless - good work, for which I would like to thank you. However, I have to put the matter on hold for now, as other build processes are still running on errors. Kind reards |
[ENH] Added Codelists as Enum (see PR #223)
great. |
Adding the backed enums in a new namespace, keeping the original names.