Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#208 Customizable PDF Metadata -> Added Templates and Callback Function #212

Merged
merged 4 commits into from
Dec 11, 2024
Merged

#208 Customizable PDF Metadata -> Added Templates and Callback Function #212

merged 4 commits into from
Dec 11, 2024

Conversation

horstoeko
Copy link
Owner

Description

Added the possibillity to customize PDF Metadata (title, subject, author) via Templates or a callback function

@horstoeko horstoeko mentioned this pull request Dec 11, 2024
Closed
#208 Customizable PDF Metadata -> Removed unused variable in PdfBuild…
7a9ade1 
…erEn16931Test::testCustomMetaInformation
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Test Results

1 983 tests  +1   1 983 ✅ +1   7s ⏱️ ±0s
   36 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 3735ae8. ± Comparison against base commit d1f0782.

♻️ This comment has been updated with latest results.

MarkusJLechner
MarkusJLechner approved these changes Dec 11, 2024
View reviewed changes
Copy link

@MarkusJLechner MarkusJLechner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

In the unit tests, I would add a case to ensure custom templates also render correctly. For example, using $pdfBuilder->setTitleTemplate('Rechnung %1$s') and asserting that the output matches Rechnung 471102.

@horstoeko horstoeko merged commit ce4b854 into master Dec 11, 2024
15 checks passed
@horstoeko horstoeko deleted the Issue_208 branch December 11, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusJLechner MarkusJLechner MarkusJLechner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horstoeko @MarkusJLechner