Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with xrechnung_2.3 and xrechnung_3.0 #18

Closed
martinemmert opened this issue Aug 31, 2023 · 5 comments · Fixed by #19 or #20
Closed

Not compatible with xrechnung_2.3 and xrechnung_3.0 #18

martinemmert opened this issue Aug 31, 2023 · 5 comments · Fixed by #19 or #20
Assignees
Labels
enhancement New feature or request

Comments

@martinemmert
Copy link

Hi there 👋

First of all - fantastic work. Thank you for building this!
Currently, this library is not up to date with new releases of the specification.
The specs for xrechnung_2.3 and xrechnung_3.0 were released by kosit.

I would love to help, but I need to figure out where to start. Can you point me in the right direction?

@horstoeko
Copy link
Owner

horstoeko commented Sep 6, 2023

Hi @martinemmert

Thank you very much for the kind words. I am just back from my summer holiday and need to find out for myself. For some reason, XRechnung 2.3 and XRechnung 3.0. Can you send me some info material on this? I will, however, go in search of information myself - but only when I have arrived here at home again... :-)

Regards

@horstoeko horstoeko added this to the v1.0.27 milestone Sep 6, 2023
@horstoeko horstoeko added the enhancement New feature or request label Sep 6, 2023
@horstoeko horstoeko self-assigned this Sep 6, 2023
horstoeko pushed a commit that referenced this issue Sep 6, 2023
horstoeko pushed a commit that referenced this issue Sep 6, 2023
@horstoeko horstoeko linked a pull request Sep 6, 2023 that will close this issue
@horstoeko horstoeko reopened this Sep 6, 2023
@horstoeko
Copy link
Owner

Hi @martinemmert,

I have added two new profiles "PROFILE_XREchnung_2_3" and "PROFILE_XREchnung_3". Possibly this should even be enough. After a first glance at the official documentation, I have not seen any serious differences (in terms of content). But I may have overlooked something. Have you seen any serious changes (especially in version 3.0)?

Regards

@horstoeko horstoeko linked a pull request Sep 6, 2023 that will close this issue
@horstoeko horstoeko reopened this Sep 6, 2023
@horstoeko
Copy link
Owner

Hi @martinemmert

I have now also added support for UniversalCommunication - at the moment only for Seller and Buyer. See Commit 9b4474e

@horstoeko
Copy link
Owner

Hi @martinemmert

I'm closing the ticket. I have made the requested implementations and checked against KosIT's current validator for the validity of the XInvoice 3.0 profile. If something is still missing, I would like to ask you to open a new issue.

@martinemmert
Copy link
Author

Hey @horstoeko thanks for looking into this that quickly. I am currently occupied and can't continue working on the project where I use this library until mid next week. Will definitely come back with feedback. 👍

Repository owner locked and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
2 participants