Fixed issue: Using addDocumentAllowanceCharge with Code SERVICE_OUTSI…

…DE_SCOPE_OF_TAX never passes validation as the Taxtype is omitted if you pass no VAT rate
horstoeko · Dec 2, 2024 · dc5a881 · dc5a881
1 parent 918faeb
commit dc5a881
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/ZugferdObjectHelper.php b/src/ZugferdObjectHelper.php
@@ -1066,7 +1066,7 @@ public function getTradeAllowanceChargeType(?float $actualAmount = null, ?bool $
         $this->tryCall($allowanceCharge, "setReasonCode", $this->getCodeType($reasonCode));
         $this->tryCall($allowanceCharge, "setReason", $this->getTextType($reason));
 
-        if (!is_null($taxCategoryCode) && !is_null($taxTypeCode) && !is_null($rateApplicablePercent)) {
+        if (!is_null($taxCategoryCode) && !is_null($taxTypeCode)) {
             $this->tryCall($allowanceCharge, "setCategoryTradeTax", $this->getTradeTaxType($taxCategoryCode, $taxTypeCode, null, null, $rateApplicablePercent));
         }