Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fatal errors : Cannot redeclare Horde_Imap_Client_Cache_Backend::… #28

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

rahal
Copy link
Contributor

@rahal rahal commented Jan 8, 2024

I don't know how it happened, but __serialize and __unserialize where defined multiple times

…__serialize() and Cannot redeclare Horde_Imap_Client_Cache_Backend_Cache::__serialize()
Copy link

what-the-diff bot commented Jan 8, 2024

PR Summary

  • Removal of __serialize() and __unserialize() methods
    In lib/Horde/Imap/Client/Cache/Backend.php, the methods responsible for preparing the object for serialization and restoring it from the serialized state have been removed. Additionally, the $this->_params property, which holds various configuration parameters, has been moved to the __unserialize() method.

  • Changes to __serialize() in Cache.php
    In lib/Horde/Imap/Client/Cache/Backend/Cache.php, there are alterations to the __serialize() method, which is used to prepare the object for serialization. The new $this->save() method being added further strengthens the object's preparation before making a call to the parent class's __serialize() method, thereby enhancing the data preservation process.

Copy link
Member

@ralflang ralflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the previous PR went wrong

@ralflang ralflang merged commit 573c97b into horde:FRAMEWORK_6_0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants