Bump foundry version in nix

[QYuQianchen]

Bump the foundry version to the latest
Make build target to ethers-rs explicit, as it builds to alloy-rs by default

[coderabbitai]

📝 Walkthrough

<details>
<summary>📝 Walkthrough</summary>

## Walkthrough
The changes involve updates to the `flake.nix` file, specifically modifying the URLs for two dependencies. The `foundry.url` has been changed to a new commit hash, indicating a version update for the Foundry dependency. Additionally, the `solc.url` has been updated to reference a new branch that supports Solidity version 0.8.24. Other dependencies remain unchanged.

## Changes

| File      | Change Summary                                                                                          |
|-----------|---------------------------------------------------------------------------------------------------------|
| flake.nix | Updated `foundry.url` from commit `ece7c960...` to `16b952aa...` and `solc.url` to branch `tb/20240129-solc-0.8.24`. |

## Sequence Diagram(s)
```mermaid
sequenceDiagram
    participant User
    participant Foundry
    participant SolidityCompiler

    User->>Foundry: Request dependency
    Foundry-->>User: Provide updated version
    User->>SolidityCompiler: Request compiler version
    SolidityCompiler-->>User: Provide support for Solidity 0.8.24

```

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between c5d6b22 and 761669f.

📒 Files selected for processing (1)

• flake.nix (1 hunks)

🔇 Additional comments (3)

flake.nix (3)

12-14: Summary: Dependencies updated successfully, but verification needed.

Both the Foundry and Solidity compiler dependencies have been updated in this PR. These changes align with the objective of keeping the project up-to-date with the latest versions of its dependencies. The updates should bring improvements and new features to the project.

However, it's crucial to verify that these updates don't introduce any breaking changes or unexpected behavior. Please ensure that you run the verification steps provided in the previous comments for both the Foundry and Solidity updates. This will help maintain the stability and compatibility of the project with these new versions.

Additionally, the PR description mentions making the build target for ethers-rs explicit. Could you please clarify how this is addressed in the current changes or if it's still pending?

To ensure a smooth update process, consider implementing a CI/CD pipeline step that automatically checks for compatibility issues when updating dependencies. This could include:

1. Compiling all smart contracts with the new Solidity version.
2. Running the entire test suite.
3. Checking for new compiler warnings or deprecation notices.
4. Reviewing changelogs of updated dependencies for breaking changes.

---

14-14: Solidity compiler update to 0.8.24 - please verify compatibility.

The update to support Solidity version 0.8.24 is a positive change that can bring new features and optimizations. However, this update wasn't explicitly mentioned in the PR description.

Please ensure that all existing contracts in the project are compatible with Solidity 0.8.24 and that no breaking changes are introduced.

To verify the Solidity version and its impact, you can run:

#!/bin/bash
# Check the new Solidity version
nix develop --command solc --version

# Compile all contracts with the new version
nix develop --command forge build

# Run tests to ensure everything still works as expected
nix develop --command forge test

# Check for any new compiler warnings
nix develop --command forge build --force | grep -i warning

---

12-12: Foundry version update looks good, but needs verification.

The update to the latest Foundry version (commit 16b952aa115c455a942eab42bbbf8b8cc69948ee) aligns with the PR objective. This update likely brings improvements and bug fixes.

However, please ensure that this update doesn't introduce any breaking changes to the project. Also, could you clarify how this update relates to making the build target for ethers-rs explicit, as mentioned in the PR description?

To verify the Foundry version and its impact, you can run:

✅ Verification successful

Foundry version update verified.

The foundry.url has been successfully updated to commit 16b952aa115c455a942eab42bbbf8b8cc69948ee in flake.nix.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check the new Foundry version
nix develop --command forge --version

# Verify that all contracts still compile with the new version
nix develop --command forge build

# Run tests to ensure everything still works as expected
nix develop --command forge test

Length of output: 456

---

Script:

#!/bin/bash
# Verify the foundry.url commit hash in flake.lock
fd "foundry.url" flake.lock | grep "16b952aa115c455a942eab42bbbf8b8cc69948ee"

Length of output: 173

---

Script:

#!/bin/bash
# Verify the foundry.url commit hash in flake.nix
rg 'foundry\.url\s*=\s*github:shazow/foundry\.nix/16b952aa115c455a942eab42bbbf8b8cc69948ee' flake.nix

Length of output: 189

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Teebor-Choka]

Does not seem to work.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 33b0fdf and c5d6b22.

📒 Files selected for processing (1)

• flake.nix (1 hunks)

🔇 Additional comments (2)

flake.nix (2)

14-14: LGTM: Solidity compiler updated to support version 0.8.24.

The solc dependency has been updated to a branch that supports Solidity version 0.8.24. This update will allow the project to use the latest features and improvements in the Solidity language.

To ensure compatibility with the new Solidity version and to identify any potential breaking changes or new features that might affect the project's smart contracts, please run the following commands:

#!/bin/bash
# Description: Verify the impact of the new Solidity version on the project's smart contracts

# 1. Check for Solidity version pragma in smart contracts
echo "Checking Solidity version pragma in smart contracts:"
rg --type solidity -n "pragma solidity" ./ethereum/contracts/src

# 2. Compile the contracts with the new Solidity version
echo "Compiling contracts with the new Solidity version:"
cd ./ethereum/contracts
forge build --force

# 3. Run the test suite to ensure everything still works
echo "Running the test suite:"
forge test -vvv

# 4. Check for any compiler warnings or new features
echo "Checking for compiler warnings or new features:"
forge build --force 2>&1 | rg -i "warning|^Error|new in"

Please review the output of these commands to ensure that:

1. The pragma statements in your contracts are compatible with the new Solidity version.
2. All contracts compile successfully with the new version.
3. All tests pass with the new version.
4. There are no unexpected compiler warnings or errors.

If you encounter any issues or warnings, you may need to update your smart contracts to be compatible with Solidity 0.8.24.

---

12-12: LGTM: Foundry version updated.

The foundry dependency has been updated to a new commit hash, which aligns with the PR objective. This change should bring in the latest improvements and fixes from the foundry project.

To ensure compatibility with the new foundry version, please run the following command to check if there are any breaking changes or new features that might affect the project:

Please review the output to ensure there are no unexpected changes that might affect the project.