Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Fix(hopp): use basename in stat cache (fix #51) #56

Merged
merged 3 commits into from
Jul 6, 2017
Merged

Fix(hopp): use basename in stat cache (fix #51) #56

merged 3 commits into from
Jul 6, 2017

Conversation

karimsa
Copy link
Member

@karimsa karimsa commented Jul 6, 2017

Relevant issues & PRs

See #51.

Notes

  • Use of : in task names is now restricted.
  • : is used to determine task nesting - basename is used as a unique key to create stat cache.

Checklist

  • This affects the tests of the project.
  • I have updated the tests as needed.

@karimsa karimsa added the bug label Jul 6, 2017
@karimsa karimsa self-assigned this Jul 6, 2017
@codecov-io
Copy link

codecov-io commented Jul 6, 2017

Codecov Report

Merging #56 into master will decrease coverage by 0.04%.
The diff coverage is 1.78%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #56      +/-   ##
=========================================
- Coverage    7.65%   7.61%   -0.05%     
=========================================
  Files          61      61              
  Lines        2651    2679      +28     
=========================================
+ Hits          203     204       +1     
- Misses       2448    2475      +27
Impacted Files Coverage Δ
packages/hopp/dist-legacy/tasks/steps.js 0% <0%> (ø) ⬆️
packages/hopp/dist/tasks/goal.js 0% <0%> (ø) ⬆️
packages/hopp/dist-legacy/tasks/parallel.js 0% <0%> (ø) ⬆️
packages/hopp/dist-legacy/tasks/goal.js 0% <0%> (ø) ⬆️
packages/hopp/dist/tasks/steps.js 0% <0%> (ø) ⬆️
packages/hopp/dist/tasks/parallel.js 0% <0%> (ø) ⬆️
packages/hopp/dist-legacy/fs/glob.js 0% <0%> (ø) ⬆️
packages/hopp/dist/fs/glob.js 96.05% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8c19e...f60b8f7. Read the comment docs.

@karimsa karimsa merged commit 2b19812 into master Jul 6, 2017
@karimsa karimsa deleted the fix_51 branch July 6, 2017 05:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants