Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Auto-Discovery / Fix missing lib for testing / Upgrade phpunit / Make it compatible with PHP 7.2 #31

Merged
merged 6 commits into from
Jun 8, 2018

Conversation

stephane-monnot
Copy link
Contributor

@stephane-monnot stephane-monnot commented May 17, 2018

  • Support Auto-Discovery
  • Fix missing lib for testing
  • Upgrade phpunit
  • Make it compatible with PHP 7.2 (related to Make it compatible with PHP 7.2 #29)
  • Remove php 5.6 7.0 compatibility

We have to remove PHP 5.6, 7.0 compatibility because laravel 5.6 and phpunit 7 require php ^7.1.3 .
Maybe create a branch before merging this PR to keep a old support branch for old version.
@hootlex What do you think about it ?

@stephane-monnot stephane-monnot changed the title Support Auto-Discovery / Fix missing lib for testing / Upgrade phpunit / Make it compatible with PHP 7.2 [WIP] Support Auto-Discovery / Fix missing lib for testing / Upgrade phpunit / Make it compatible with PHP 7.2 May 17, 2018
@stephane-monnot stephane-monnot changed the title [WIP] Support Auto-Discovery / Fix missing lib for testing / Upgrade phpunit / Make it compatible with PHP 7.2 Support Auto-Discovery / Fix missing lib for testing / Upgrade phpunit / Make it compatible with PHP 7.2 May 17, 2018
@hootlex
Copy link
Owner

hootlex commented May 17, 2018

Thank you Stephane ❤️

Would it be possible to keep php 5.6 support and only update the dev-dependencies for testing on Travis?

If we are about to drop support for php 5.6 this should be a major version so it doesn't affect users that are still using it.

@stephane-monnot
Copy link
Contributor Author

You're welcome :)
It's possible to keep php 5.6 support, but we can't test it with Travis, because the class TestCase of Laravel uses Phpunit 7 and Laravel itself uses PHP7.1.
Do you want me to revert this change :

"require": {
-    "php": ">=5.4.0"
+    "php": "^7.1.3"
},

@hootlex
Copy link
Owner

hootlex commented May 22, 2018

@stephane-monnot Thanks for explaining. I think it's acceptable to not test it in Travis but keep support for php 5.6 until the package is not compatible any more.

@stephane-monnot
Copy link
Contributor Author

Done

@hootlex hootlex merged commit 1ae3aa8 into hootlex:master Jun 8, 2018
@hootlex
Copy link
Owner

hootlex commented Jun 8, 2018

@stephane-monnot thank you!

This was referenced Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants