Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/setup-state-persistence #26

Merged
merged 15 commits into from
Feb 9, 2019

Conversation

imranariffin
Copy link
Member

@imranariffin imranariffin commented Feb 7, 2019

  • load state from storage on app startup
  • save state to storage on every api success action
  • improve: save state only when needed

@imranariffin imranariffin self-assigned this Feb 7, 2019
@cglotr
Copy link
Member

cglotr commented Feb 7, 2019

@imranariffin I think we should go over the app code base during this week's meeting. I need to get ramped up on the code and hopefully, I am able to contribute to client-side this weekend.

@imranariffin
Copy link
Member Author

imranariffin commented Feb 7, 2019 via email

@imranariffin imranariffin force-pushed the feature/setup-state-persistence branch from 6a911bf to 2338051 Compare February 9, 2019 14:13
@imranariffin imranariffin changed the title WIP feature/setup-state-persistence feature/setup-state-persistence Feb 9, 2019
Copy link
Member

@cglotr cglotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@imranariffin imranariffin merged commit 13f4e03 into develop Feb 9, 2019
isSuccess: 'isSuccess'
})
})
})
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add end of line

@cglotr cglotr deleted the feature/setup-state-persistence branch February 9, 2019 16:11
@imranariffin
Copy link
Member Author

#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants