Skip to content

Commit

Permalink
SOAP action value is not needed in order to invoke the service.
Browse files Browse the repository at this point in the history
There are some web services declaring operations in their WSDLs with
soapAction attribute empty. This seems to still be WS-I compliant so
we are going to go ahead and generate operations anyway. Also, the
SOAP envelope carries all the information required by the server
in order to know exactly what operation is being invoked. And, servers
should not rely in the value of the SOAPAction HTTP header as per point
3.4.3 in http://www.ws-i.org/profiles/basicprofile-1.1-2004-08-24.html
  • Loading branch information
c4milo committed Nov 3, 2014
1 parent 308da7e commit 3df82da
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions generator/operations_tmpl.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ var opsTmpl = `
{{$soapAction := findSoapAction .Name $portType}}
{{$output := findType .Output.Message}}
{{if ne $soapAction ""}}
{{/*if ne $soapAction ""*/}}
{{if gt $faults 0}}
//
// Error can be either of the following types:
Expand All @@ -45,7 +45,7 @@ var opsTmpl = `
return response, nil
}
{{end}}
{{/*end*/}}
{{end}}
{{end}}
`

0 comments on commit 3df82da

Please sign in to comment.