Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add --cli-path flag support #90

Closed
wants to merge 1 commit into from

Conversation

leggetter
Copy link
Collaborator

No description provided.

@leggetter leggetter changed the base branch from main to listen-multiple July 21, 2024 00:44
@alexluong
Copy link
Collaborator

alexluong commented Jul 23, 2024

I'm thinking, as we may make changes to the destination on Hookdeck if the CLI path doesn't match, I wonder if we should communicate it to the user more clearly to avoid unintended behavior.

I'm taking inspiration from Terraform, so we can have something along the line of:

$ hookdeck listen 3000 my_source --cli-path /new/path

Source "my_source" has a connection to "my_cli_destination" with a CLI path of "/old/path". Would you like to update it on Hookdeck? ...yes/no

This way, it's a bit interactive and we can avoid making changes that the users don't expect. To skip the interactivity part, we can do --auto-approve or something like that to make it more straightforward.

What do you think? I could be overthinking a behavior that doesn't warrant this level of caution?

cc @mkherlakian

@leggetter
Copy link
Collaborator Author

Superseded by #92

@leggetter leggetter closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants