-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oidc-auth): support absolute path for redirect URI #926
feat(oidc-auth): support absolute path for redirect URI #926
Conversation
🦋 Changeset detectedLatest commit: 9163976 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@hnw Thanks! This is a good feature! Hey @maemaemae3! Can you review this? |
looks super useful feature, I will use it once it's released, thank you! |
Change variable names to camelCase Co-authored-by: tempepe <maekawa@tempepe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@maemaemae3 Thank you for the review! @hnw Looks good! Let's go with this. Merging and releasing a new version. Thank you! |
Summary
The
OIDC_REDIRECT_URI
was initially expected to be a full URL, but rewriting the URL for development and production environments is cumbersome. By supporting absolute paths such as/callback
, we aim to reduce the developer’s effort.Changes
OIDC_REDIRECT_URI
and set the default value to/callback
.Testing
OIDC_REDIRECT_URI
is a relative path and when it is not set.Tasks
yarn changeset
at the top of this repo and push the changeset