-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helper/adapter): correct env
type
#3885
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3885 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 162 162
Lines 10263 10263
Branches 2908 2939 +31
=======================================
Hits 9317 9317
Misses 945 945
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Hey @EdamAme-x Please review this! |
okay, I am looking into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundle size check
Compiler Diagnostics
Reported by octocov |
Thank you for the review and the PR! But I noticed there is a condition we have not checked. I've added a test and fixed the type definition. a0b57db So, your PR will be unnecessary, but I think this PR is okay. Can you review this again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@EdamAme-x Thank you so much! |
Fixes honojs/website#577
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code