Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper/adapter): correct env type #3885

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Feb 3, 2025

Fixes honojs/website#577

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

This comment has been minimized.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (093d3fd) to head (a0b57db).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3885   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files         162      162           
  Lines       10263    10263           
  Branches     2908     2939   +31     
=======================================
  Hits         9317     9317           
  Misses        945      945           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe
Copy link
Member Author

yusukebe commented Feb 3, 2025

Hey @EdamAme-x Please review this!

@EdamAme-x
Copy link
Contributor

EdamAme-x commented Feb 3, 2025

okay, I am looking into this.

Copy link
Contributor

@EdamAme-x EdamAme-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missclick.

@yusukebe
Can you check this?
#3887

Copy link

github-actions bot commented Feb 4, 2025

Bundle size check

main (65edaf2) #3885 (12c8a0c) +/-
Bundle Size (B) 18,757B 18,757B 0B
Bundle Size (KB) 18.32K 18.32K 0K

Compiler Diagnostics

main (65edaf2) #3885 (12c8a0c) +/-
Files 257 257 0
Lines 115,048 115,048 0
Identifiers 112,928 112,928 0
Symbols 301,429 301,429 0
Types 213,638 213,638 0
Instantiations 3,090,073 3,090,073 0
Memory used 444,729K 451,625K 6,896K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.68s 0.67s -0.01s
Bind time 0.31s 0.3s -0.01s
Check time 5.81s 5.77s -0.04s
Emit time 0s 0s 0s
Total time 6.8s 6.75s -0.05s

Reported by octocov

@yusukebe
Copy link
Member Author

yusukebe commented Feb 4, 2025

@EdamAme-x

Thank you for the review and the PR! But I noticed there is a condition we have not checked. I've added a test and fixed the type definition. a0b57db

So, your PR will be unnecessary, but I think this PR is okay. Can you review this again?

Copy link
Contributor

@EdamAme-x EdamAme-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yusukebe
Copy link
Member Author

yusukebe commented Feb 4, 2025

@EdamAme-x Thank you so much!

@yusukebe yusukebe merged commit 0847a08 into main Feb 4, 2025
16 checks passed
@yusukebe yusukebe deleted the fix/helper-adapter-env-type branch February 4, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants