Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): standardize use of notes #538

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Sep 3, 2024

Noticed while browsing the provider docs that the use of "callouts" (largely used for notes) is a bit inconsistent.

This change attempts to fix that, while using the available yellow and red callouts for warnings and deprecation notices.

@jharley jharley requested a review from a team as a code owner September 3, 2024 14:46
@@ -2,7 +2,7 @@

The `honeycombio_column` data source retrieves the details of a single column in a dataset.

-> **Note** Terraform will fail unless a column is returned by the search. Ensure that your search is specific enough to return a column.
~> **Warning** Terraform will fail unless a column is returned by the search. Ensure that your search is specific enough to return a column.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm still a lil confused what this will end up looking like based on this table.

image

Will this end up as a yellow callout with the text prefix **Note** **Warning**, since it's using ~>?

I also notice that it says !> is supposed to end up with a red callout and the **Warning** prefix, but for all of our callouts that say "Warning" we're using ~> -- is that what we want? (my guess is yes since they seem like less important warnings, but wanted to check)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing a **Something** overrides the default text prefix, so the above renders like this:

image

I should have linked their Doc Preview Tool which lets you try out their flavor of Markdown

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks! I'll bookmark that for later, I did not realize it was an override but that sounds perfect.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.23%. Comparing base (b2f8d6f) to head (bc9d3cd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #538   +/-   ##
=======================================
  Coverage   79.23%   79.23%           
=======================================
  Files          75       75           
  Lines        5963     5963           
=======================================
  Hits         4725     4725           
  Misses        915      915           
  Partials      323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley merged commit 895e2a5 into main Sep 3, 2024
6 checks passed
@jharley jharley deleted the jharley.fix-doc-note-formatting branch September 3, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants