maint: change title on release workflow from (unset) var to hard-coded string #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieDanielson
added
type: maintenance
vreynolds
reviewed
Jul 6, 2022
| @@ -2,6 +2,7 @@ name: Create helm chart issue on release | |||
| on: | |||
| release: | |||
| types: [published] | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
is this an intentional change?
There was a problem hiding this comment.
workflow_dispatch is the command to run a workflow on-demand. I was hoping this would give me an option right from this PR to test it, but I'm not seeing it (unless I'm missing it somewhere). So I'm thinking we keep it in so I can try it manually after merging to main to see if it creates an issue properly, and if it doesn't, then we know this workflow still doesn't work (as opposed to waiting for the next release to see that it doesn't work). Open to rejection on that idea though, keep only the change to the title field, and just see what happens.
vreynolds
approved these changes
Jul 6, 2022
|
This still did not work 😞 Created new issue #476 for next effort. |
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
…d string (honeycombio#474) Error in previous workflow that attempted to create an issue states "Input required and not supplied: title". While the title does match that of the example provided in the actions repo, it is based on a variable that is set in the example that we do not have set. I believe this is causing a blank title which is not allowed, as the title value is required. This PR changes the title from a variable that is unset ({ steps.date.outputs.today }}) to a hard-coded string (Bump Refinery to Latest Version).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
{ steps.date.outputs.today }}) to a hard-coded string (Bump Refinery to Latest Version).