[dev/ci] test in dev and CI the same way #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for whether Redis is running with Make, so the dev and CI environments run similarly and show the same warnings. Now the tests can be only "make test"!
robbkidd
force-pushed
the
robb.easier-testing-in-dev
branch
from
7ca4bf9 to
558de72
Compare
robbkidd
added
type: maintenance
robbkidd
force-pushed
the
robb.easier-testing-in-dev
branch
from
aed2670 to
866b288
Compare
|
@MikeGoldsmith Here's the product of our discussion today about testing in dev. I'd say only the first commit is the minimum to add make targets for the project's test commands. Everything after that was about getting the "check that Redis is available" working in dev and CI, too, and rubbing caches on things. |
robbkidd
force-pushed
the
robb.easier-testing-in-dev
branch
from
866b288 to
786a4eb
Compare
MikeGoldsmith
approved these changes
Oct 7, 2021
ghost
pushed a commit
to opsramp/tracing-proxy
that referenced
this pull request
Jul 5, 2024
* add convenience make targets for testing * add dockerize to test targets Check for whether Redis is running with Make, so the dev and CI environments run similarly and show the same warnings. Now the tests can be only "make test"! * cache the downloaded dockerize in CI * cache go dependencies in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Adds a Makefile
Adds "test_with_race" and "test_all" make targets for the two test commands CI had been running
Adds a "test" target to run both
Adds targets for retrieving and running dockerize to verify Redis is available before running the test suite
Caches the dockerize release asset
Caches the go mod dependencies
I'll note that the caching didn't save any appreciable time on the test runs that took advantage of the caches.