feat: store trace kept record with pipelining instead of lua script #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
approved these changes
Jun 5, 2024
tdarwin
pushed a commit
to tdarwin/refinery
that referenced
this pull request
Jun 26, 2024
…oneycombio#1188) <!-- Thank you for contributing to the project! 💜 Please make sure to: - Chat with us first if this is a big change - Open a new issue (or comment on an existing one) - We want to make sure you don't spend time implementing something we might have to say No to - Add unit tests - Mention any relevant issues in the PR description (e.g. "Fixes honeycombio#123") Please see our [OSS process document](https://github.com/honeycombio/home/blob/main/honeycomb-oss-lifecycle-and-practices.md#) to get an idea of how we operate. --> ## Which problem is this PR solving? We found the keep trace lua script in redis' slow query log. Turns out, we actually don't need to store those fields separately since they don't change once they are set. By storing them together, we can eliminate the need for using lua script. ## Short description of the changes - Define a `KeepRecord` field in the data structure we use to store trace status in redis - encode `centralTraceStatusReason` into one json blob - change redis to allow easier pipelining commands TODO: Since we have changed most of our redis_store code to use pipelining when communicating with redis, I will make another PR to clean up the redis.go code that enables a easier interface for using pipelining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We found the keep trace lua script in redis' slow query log. Turns out, we actually don't need to store those fields separately since they don't change once they are set. By storing them together, we can eliminate the need for using lua script.
Short description of the changes
KeepRecordfield in the data structure we use to store trace status in rediscentralTraceStatusReasoninto one json blobTODO:
Since we have changed most of our redis_store code to use pipelining when communicating with redis, I will make another PR to clean up the redis.go code that enables a easier interface for using pipelining