Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-slugified environment names #407

Closed
MikeGoldsmith opened this issue Feb 17, 2022 · 0 comments · Fixed by #410
Closed

Support non-slugified environment names #407

MikeGoldsmith opened this issue Feb 17, 2022 · 0 comments · Fixed by #410
Assignees
@JamieDanielson
Labels
type: enhancement New feature or request

Comments

@MikeGoldsmith
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When configuring an environment in the rule configuration, the environment's slugified name must be used as that is what is returned by the Honeycomb API.

This isn't as obvious as it could be, and supporting the non-slugified version of the environment name might be useful.

Describe the solution you'd like
Be able to provide either slugified or non-slugified name of the environment when configuring rules.

Describe alternatives you've considered
The Honeycomb API only returns the slugified version, it could return both versions.

Additional context
@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Feb 17, 2022
This was referenced Feb 17, 2022
Merged
Merged
@JamieDanielson JamieDanielson self-assigned this Feb 22, 2022
@JamieDanielson JamieDanielson mentioned this issue Feb 23, 2022
Merged
JamieDanielson added a commit that referenced this issue Feb 24, 2022
@JamieDanielson
feat: add support for env name from auth (#410)
6932877 
* add support for env name from auth
* use only env name in auth call and cache

closes [Support non-slugified environment names](#407) #407
* Environment name will be returned in auth call in addition to slug.
* Environment slug is no longer supported in the rules file. If it becomes an issue and there is high demand for it, we can consider adding it as an option later.
* Using the environment name instead of the slug is more intuitive for end users, as they set the environment name intentionally, not the slug. This can now be used in the rules config instead of worrying about the structure of the slugified version of the environment.
ghost pushed a commit to opsramp/tracing-proxy that referenced this issue Jul 5, 2024
@JamieDanielson
feat: add support for env name from auth (honeycombio#410)
b8840ac 
* add support for env name from auth
* use only env name in auth call and cache

closes [Support non-slugified environment names](honeycombio#407) honeycombio#407
* Environment name will be returned in auth call in addition to slug.
* Environment slug is no longer supported in the rules file. If it becomes an issue and there is high demand for it, we can consider adding it as an option later.
* Using the environment name instead of the slug is more intuitive for end users, as they set the environment name intentionally, not the slug. This can now be used in the rules config instead of worrying about the structure of the slugified version of the environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamieDanielson JamieDanielson

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for env name from auth honeycombio/refinery
2 participants
@MikeGoldsmith @JamieDanielson