Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer communication failures when using SendKey feature #1376

Closed
VinozzZ opened this issue Oct 10, 2024 · 0 comments
Closed

Peer communication failures when using SendKey feature #1376

VinozzZ opened this issue Oct 10, 2024 · 0 comments
Assignees
@VinozzZ
Labels
type: bug Something isn't working
Milestone
v2.9

Comments

@VinozzZ
Copy link
Contributor

VinozzZ commented Oct 10, 2024

Versions

  • Refinery: 2.8.2

Steps to reproduce

  1. configure a SendKey
  2. configure a list of ReceiveKeys that doesn't contain the SendKey
  3. set AcceptOnlyListedKeys to true

Run Refinery and error messages like below will show up

time="2024-10-09T08:55:55Z" level=error msg="error when sending event" api_host="http://peer-address:8081/" dataset=teams-api environment="test" error="got unexpected HTTP status 400: Bad Request"

Additional context
Adding the send key to the list of accepted receive keys has worked around it
@VinozzZ VinozzZ added the type: bug Something isn't working label Oct 10, 2024
@VinozzZ VinozzZ added this to the v2.9 milestone Oct 17, 2024
@VinozzZ VinozzZ mentioned this issue Oct 30, 2024
Merged
@VinozzZ VinozzZ self-assigned this Oct 30, 2024
VinozzZ added a commit that referenced this issue Nov 8, 2024
@VinozzZ @MikeGoldsmith
fix: replace api key with SendKey before transmission (#1404)
909ef50 
## Which problem is this PR solving?

Replacing API key with the configured SendKey in the router causes peer
communication to fail due to api key validation on both peer and
incoming traffic.

To resolve this issue, this PR adjusts the replacement logic to occur
immediately before transmission.
- #1376 

## Short description of the changes

- only check if the api key is acceptable in the router
- do replacement in `sendTraces`

---------

Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
@VinozzZ VinozzZ closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VinozzZ VinozzZ

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v2.9
Development

No branches or pull requests
1 participant
@VinozzZ