Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract unique sampling fields from config #1325

Closed
VinozzZ opened this issue Sep 12, 2024 · 0 comments · Fixed by #1327
Closed

Abstract unique sampling fields from config #1325

VinozzZ opened this issue Sep 12, 2024 · 0 comments · Fixed by #1327
Assignees
@VinozzZ
Milestone
v2.9

Comments

@VinozzZ
Copy link
Contributor

VinozzZ commented Sep 12, 2024

In order to abstract key fields from each incoming spans, we need to be able to retrieve the defined sampling fields from config.
@VinozzZ VinozzZ added this to the v2.9 milestone Sep 12, 2024
@VinozzZ VinozzZ self-assigned this Sep 12, 2024
@VinozzZ VinozzZ mentioned this issue Sep 12, 2024
Merged
This was referenced Sep 16, 2024
Closed
Closed
Closed
VinozzZ added a commit that referenced this issue Sep 16, 2024
@VinozzZ
feat: extract key fields from rules config (#1327)
45874a2 
## Which problem is this PR solving?

Extract sampling fields from config so that we can use it to construct
key fields only spans

fixes: #1325 

## Short description of the changes

- add `GetSamplingFielder` interface to sampler config
- add `GetKeyFields` to all samplers
TylerHelmuth pushed a commit that referenced this issue Oct 16, 2024
@VinozzZ @TylerHelmuth
feat: extract key fields from rules config (#1327)
0249305 
## Which problem is this PR solving?

Extract sampling fields from config so that we can use it to construct
key fields only spans

fixes: #1325 

## Short description of the changes

- add `GetSamplingFielder` interface to sampler config
- add `GetKeyFields` to all samplers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VinozzZ VinozzZ

Labels
None yet
Projects
None yet
Milestone
v2.9
Development

Successfully merging a pull request may close this issue.

feat: extract key fields from rules config honeycombio/refinery
1 participant
@VinozzZ