maint: Bump OTel dependencies #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
version: bump minor
JamieDanielson
added
the
breaking-change
JamieDanielson
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
This looks good - I opened PR #87 against this because it's typically best to upgrade all otel packages together, including both core and contrib. If that looks good feel free to approve and merge it in, then this one is good to go
## Which problem is this PR solving? - OpenTelemetry Go should typically get updated with both core and contrib packages ## Short description of the changes - Update contrib packages to [v1.21.0/v0.46.0](https://github.com/open-telemetry/opentelemetry-go-contrib/releases/tag/v1.21.0) to match the corresponding core packages v1.20.0/v0.43.0 ## How to verify that this has the expected result All tests pass. This is to be merged into Mike's PR #84 that updates the main go packages and sets minimum go version to 20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Bumps OTel dependencies to latest versions. This update includes moving the metrics experimental package into the main sdk package which was a breaking change for many users, and would prevent users of this config library from adopting a newer version.
Also, v1.20 no longer supports go 19 and the minimum version of go is 20. This PR updates the go versions unit tests are run with to remove 19 and add 21.
Short description of the changes
How to verify that this has the expected result?
Unit & smoke tests continue to pass and users who want to use v1.20.0 and higher can.