feat: URL encode dataset #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
type: enhancement
version: bump minor
MikeGoldsmith
force-pushed
the
mike/urlencode-dataset
branch
from
7a7d4a5
to
3faf7e1
Compare
MikeGoldsmith
force-pushed
the
mike/urlencode-dataset
branch
5 times, most recently
from
cad2370
to
99ad56a
Compare
MikeGoldsmith
force-pushed
the
mike/urlencode-dataset
branch
from
99ad56a
to
95c18f1
Compare
cartermp
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
When sending data, the dataset name forms part of the URL path and should be URL encoded so restricted characters are preserved. This is particularly important if the dataset name included a forward slash
/which results in an invalid URL path and the Honeycomb API rejecting the request.Short description of the changes