Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix race condition on Honeycomb.Flush() #140

Merged
merged 2 commits into from
Sep 24, 2021
Merged

fix race condition on Honeycomb.Flush() #140

merged 2 commits into from
Sep 24, 2021
+32 −1

Conversation

bfreis
Copy link
Contributor

@bfreis bfreis commented Sep 23, 2021

Which problem is this PR solving?

Short description of the changes

  • Eliminates the race condition on accessing the old muster by reading it only after acquiring the corresponding mutex.

@bfreis bfreis requested a review from a team September 23, 2021 22:00
@vreynolds vreynolds self-assigned this Sep 24, 2021
vreynolds
vreynolds approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🙇‍♀️

@vreynolds vreynolds added the version: bump patch A PR with release-worthy changes and is backwards-compatible. label Sep 24, 2021
@vreynolds vreynolds merged commit ff38639 into honeycombio:main Sep 24, 2021
@bfreis bfreis deleted the flush-race-condition branch September 25, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vreynolds vreynolds vreynolds approved these changes

Assignees

@vreynolds vreynolds

Labels
type: bug version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bfreis @vreynolds