Mask writekey when printing events #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin308
approved these changes
Nov 5, 2020
|
I've created tickets to verify behaviour in other SDKs. |
MikeGoldsmith
added a commit
that referenced
this pull request
Jun 21, 2021
….response_test * 'main' of github.com:honeycombio/libhoney-go: (42 commits) prepare v1.15.3 release (#126) Bump github.com/klauspost/compress from 1.11.13 to 1.12.2 (#122) Bump github.com/klauspost/compress from 1.11.8 to 1.11.13 (#120) Add go 1.16 to the testing matrix (#119) Bump github.com/klauspost/compress from 1.11.7 to 1.11.8 (#118) Bump github.com/DataDog/zstd from 1.4.5 to 1.4.8 (#117) Add more context to batch response parsing error (#116) Add go 1.15 to the testing matrix (#114) Bump github.com/klauspost/compress from 1.11.4 to 1.11.7 (#112) Prepare v1.15.2 release (#113) add our custom action to manage project labels (#110) automate the creation of draft releases when project is tagged with a version number (#109) Prepare for v1.15.1 (#108) Fix data race on dynFields length in Builder.Clone (#72) Bump github.com/klauspost/compress from 1.11.3 to 1.11.4 (#106) Bump github.com/klauspost/compress from 1.11.2 to 1.11.3 (#105) prepare 1.15.0 release (#104) Bump github.com/klauspost/compress from 1.11.0 to 1.11.2 (#102) mask writekey when printing events (#103) Bump github.com/klauspost/compress from 1.10.11 to 1.11.0 (#101) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally an event may be printed in a debug message. However, an event contains the
writekeywhich is sensitive and shouldn't be shared.This change masks the apikey so only he last four characters are visible, with the remainder is masked with
X.